bazel-tools

bazel-tools copied to clipboard

Do not hard code version

2

I suggest to make the actual version and SHA256 of the binaries (i.e. golangci-lint) to be customizable for downstream repo to source from this repo directly. Otherwise downstream repos will...

sluongng

Golangci-lint on generated code

2

Hi, I've hacked together a small patch that allows running `golangci-lint` on the generated go code. It relies on [`@rules_go/go_path`](https://github.com/bazelbuild/rules_go/blob/master/go/core.rst#go-path) to assemble a source tree of all the dependencies and...

parabolala

@obweger Hi Hannes! Could you help me re-enable the Buildkite integration for this repo please? The webhook is configured correctly and builds are triggered, but they don't have permissions to...

ash2k

Symlink cycle

1

It looks like this line causes issues with newer versions of Bazel (I'm using `0.24.1`): https://github.com/atlassian/bazel-tools/blob/c7e0fd9070f04f88bf671e57f101aa0877a9b5c8/goimports/runner.bash.template#L11 When running e.g. `bazel build //...` I get: ``` ERROR: infinite symlink expansion detected...

macduy

See how it is implemented in rjsone rule as an example.

ash2k