website icon indicating copy to clipboard operation
website copied to clipboard

feat: adding GSoD and GSoC pages

Open quetzalliwrites opened this issue 3 years ago โ€ข 18 comments

Contribution Description

The purpose of this PR is to create 2 NEW pages on our website for /GSoD (Google Season of Docs) and /GSoC(Google Summer of Code). In addition to adding those 2 pages to our website, I'm also proposing adding nav links to these pages under the Community nav group.

Screen Shot 2022-03-30 at 3 51 33 PM

I truly love the idea of having them under Community because they are (potentially) a huge group event to do with the whole community. It just seemed to fit under that section best. But I know (as you can see too) that the sub-nav <li>s look like a long list now, so I will understand if you folks are wondering about that. Perhaps the styling should change to make the dropdown be a wider rectangle horizontally vs the current vertical grid?

Page sources

quetzalliwrites avatar Mar 30 '22 23:03 quetzalliwrites

Deploy Preview for asyncapi-website failed.

Built without sensitive environment variables

Name Link
Latest commit 96108ee881a335af4983bb839795e234a90b7e36
Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/62a99f5684a9d600083fb14a

netlify[bot] avatar Mar 30 '22 23:03 netlify[bot]

Questions

Hey @derberg and @magicmatatjahu, I have a few development questions since this is the first time I add new pages to the website outside of the Docs markdown arena. ๐Ÿ˜„

Problem 1

Regardless of what I tried, HTML <table> and <ul> elements don't display as expected.

  • The ๐ŸŸฉ box shows <ul> elements
  • The ๐ŸŸฆ box shows a <table> element
Screen Shot 2022-03-30 at 3 53 59 PM

In fact, there is only 1 section that displays the ยท (list item bullet point) as expected in the <ul> element:

Screen Shot 2022-03-30 at 4 32 38 PM

When I compare the code samples, the only diff seemed to be that one of the <ul> elements had it's own <div>. So I tried to shuffle the other <ul> elements and give them their own <div>s to see if that fixed it. It didn't, ๐Ÿ˜‚ so I put them back as they were: Screen Shot 2022-03-30 at 4 34 14 PM Screen Shot 2022-03-30 at 4 34 25 PM

Problem 2

When I open my 8080 localhost link to preview these pages, the website's main navigation seems to disappear!

What did I do? Where did it go? ๐Ÿ™Š๐Ÿ˜‚๐Ÿ˜‚

Screen Shot 2022-03-30 at 3 53 21 PM

quetzalliwrites avatar Mar 30 '22 23:03 quetzalliwrites

@alequetzalli As I see, this is copy/paste of the discussion's content about GSOC and GSOD. If we wanna these sites we should render them as mdx not as html. I can help but I need "approval" from @fmvilas and @derberg that these pages are needed :)

magicmatatjahu avatar Apr 06 '22 09:04 magicmatatjahu

I'm definitely up for this change. Many orgs do it for transparency reasons on their involvement in different mentorship programs. It will also make it super easy for us to share our participation and share resources in future, because some rules do not change.

My suggestion though is to not have it as asyncapi.com/community/gsoc but asyncapi.com/community/mentorship/gsoc so we basically get:

  • a "docs" like landing page under asyncapi.com/community/mentorship with navigation on the left, with links to Google Summer of Code and others and some short summary about these, like even hall of fame of those that completed. Like also have CodeForce participation update, then we will have Outreachy in few months, etc. But most important, we will get also a place to describe AsyncAPI Mentorship
  • contend developed with markdown/mdx

derberg avatar Apr 07 '22 09:04 derberg

I'm definitely up for this change. Many orgs do it for transparency reasons on their involvement in different mentorship programs. It will also make it super easy for us to share our participation and share resources in future, because some rules do not change.

My suggestion though is to not have it as asyncapi.com/community/gsoc but asyncapi.com/community/mentorship/gsoc so we basically get:

@derberg Sure, I can move these pages into a sub-folder called community so that we end up with:

  • asyncapi.com/community/mentorship/gsoc
  • asyncapi.com/community/mentorship/gsod
  • a "docs" like landing page under asyncapi.com/community/mentorship with navigation on the left, with links to Google Summer of Code and others and some short summary about these, like even hall of fame of those that completed. Like also have CodeForce participation update, then we will have Outreachy in few months, etc. But most important, we will get also a place to describe AsyncAPI Mentorship
  • contend developed with markdown/mdx

Errrr. what now? @derberg sorry, got confused here a bit... can you show me a drawing of what you mean by "with navigation on the left, with links to Google Summer of Code and others and some short summary about these, like even hall of fame of those that completed".

(Also for the purposes of this PR, the scope is only adding these 2 pages.)

BTW, @magicmatatjahu can you confirm you know how to fix the CSS/styling issues I documented here? Lukasz was the one who told me I should tag you in this issue.

quetzalliwrites avatar Apr 07 '22 19:04 quetzalliwrites

@alequetzalli

can you confirm you know how to fix the CSS/styling issues I documented here? Lukasz was the one who told me I should tag you in this issue.

When we will move to the mdx probably all issues will be resolved :) If you want I can push some changes to your branch. Let me know :)

magicmatatjahu avatar Apr 08 '22 10:04 magicmatatjahu

@alequetzalli sorry for not explaining well. I mean look at Getting Started navigation. Screenshot 2022-04-11 at 10 40 20

So by going to asyncapi.com/community/mentorship we would see in navigation like โ˜๐Ÿผ elements like Google Summer of Code or Open Force or Google Season of Docs or Hacktoberfest or Outreachy or most important AsyncAPI Mentorship. So asyncapi.com/community/mentorship would be a single place where we have all different programs described and how we deal with them.

But yes, scope of this PR is GSoC and GSoD as a starter

derberg avatar Apr 11 '22 08:04 derberg

When we will move to the mdx probably all issues will be resolved :) If you want I can push some changes to your branch. Let me know :)

Yes, @magicmatatjahu you can totally push changes to my branch. You have alllll the permissions! โœจโœจโœจโœจโœจโœจโœจ ๐Ÿ™๐Ÿฝ

quetzalliwrites avatar Apr 13 '22 21:04 quetzalliwrites

So by going to asyncapi.com/community/mentorship we would see in navigation like โ˜๐Ÿผ elements like Google Summer of Code or Open Force or Google Season of Docs or Hacktoberfest or Outreachy or most important AsyncAPI Mentorship. So asyncapi.com/community/mentorship would be a single place where we have all different programs described and how we deal with them.

Huh๐Ÿค”.. ok I think I get it now ๐Ÿ˜„ @derberg

quetzalliwrites avatar Apr 13 '22 21:04 quetzalliwrites

removed gsoc and gsod labels as we add them to ideas issues for mentees

derberg avatar Apr 16 '22 16:04 derberg

โšก๏ธ Lighthouse report for the changes in this PR:

Category Score
๐ŸŸ  Performance 52
๐ŸŸ  Accessibility 74
๐ŸŸ  Best practices 83
๐ŸŸข SEO 90
๐Ÿ”ด PWA 30

Lighthouse ran on https://deploy-preview-642--asyncapi-website.netlify.app/

github-actions[bot] avatar Apr 21 '22 11:04 github-actions[bot]

@alequetzalli @derberg I added content as markdown. After merging PR with new navigation for docs I will improve navigation also for new pages in this PR, but for now we have to wait. Adding new pages for the /community/mentorship subpage is similar to adding new docs. You can check it out here: https://deploy-preview-642--asyncapi-website.netlify.app/community/mentorship

magicmatatjahu avatar Apr 21 '22 11:04 magicmatatjahu

@magicmatatjahu just headings and titles are duplicated, but yeah, not code issue but fact that it is duplicated in metadata.

Looks nice โค๏ธ

derberg avatar Apr 26 '22 16:04 derberg

@derberg Yeah, I duplicated the data just to show that new pages are being rendered :)

magicmatatjahu avatar Apr 26 '22 16:04 magicmatatjahu

@magicmatatjahu where are we with this one?

derberg avatar May 23 '22 09:05 derberg

@derberg

https://github.com/asyncapi/website/pull/642#issuecomment-1105080050

After merging this PR https://github.com/asyncapi/website/pull/601 I will update navigation and you can review it :)

magicmatatjahu avatar May 23 '22 09:05 magicmatatjahu

We need to wait for https://github.com/asyncapi/website/pull/830

magicmatatjahu avatar Jun 21 '22 08:06 magicmatatjahu

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Oct 20 '22 00:10 github-actions[bot]

Closing because work is done in https://github.com/asyncapi/community/pull/571

Of course we can reopen if needed

derberg avatar Feb 28 '23 16:02 derberg