asyncapi
[BUG] Newsletter page does not have correct button labels
Describe the bug.
The labels for the buttons and input fields simply have the i18n placeholders instead of the actual labels
Expected behavior
These are the expected labels
How to Reproduce
- Go to https://www.asyncapi.com/newsletter or https://www.asyncapi.com/community/tsc
- You will notice the improper labels
🥦 Browser
Google Chrome
👀 Have you checked for similar open issues?
- [X] I checked and didn't find similar issue
🏢 Have you read the Contributing Guidelines?
- [X] I have read the Contributing Guidelines
Are you willing to work on this issue ?
No, someone else can work on it
How do we access newsletter page?
I am not sure either, I was just going through the codebase and found that we have pages/newsletter.tsx file. Which means the page exists at https://www.asyncapi.com/newsletter
@akshatnema do we need this url as we only have newsletter at the home page which is working fine
Found it. Here is how you can access the /newsletter page
1. Go to the footer of the website.
2. Click on About
3. Now on the about page. you will find a link to the newsletter
That's not it. The newsletter page is also linked from multiple blogs
Hey,@JeelRajodiya can you assign this to me.
Issues are not assigned on the website repo (AFAIK). If the issue is valid, you can start working on it and a create PR.
@JeelRajodiya I can still see this issue present on the website.Can i work on this ?
@JeelRajodiya I can still see this issue present on the website.Can i work on this ?
I think PR https://github.com/asyncapi/website/pull/3308 is relevant to this issue and is still under review. You should avoid working on the issues which already have a PR open.
@sambhavgupta0705 I think the issue was resolved in #3308. We can close this issue.