server-api icon indicating copy to clipboard operation
server-api copied to clipboard

Move to the npm ci in the Dockerfile

Open magicmatatjahu opened this issue 4 years ago • 10 comments

As in current Dockerfile we install dependencies by npm install due to problem described in the https://github.com/asyncapi/.github/issues/123 issue. After resolving mentioned issue we should move from npm install to the npm ci.

magicmatatjahu avatar Jan 17 '22 16:01 magicmatatjahu

Is this issue is resolved? and Remained to close?

abhijeetjejurkar avatar Mar 18 '22 18:03 abhijeetjejurkar

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Jul 17 '22 00:07 github-actions[bot]

@abhijeetjejurkar Nope, we still use npm install https://github.com/asyncapi/server-api/blob/master/Dockerfile#L17

magicmatatjahu avatar Sep 29 '22 10:09 magicmatatjahu

hi @magicmatatjahu, the PR https://github.com/asyncapi/.github/issues/123 is necessary to be merged first right? Could we do this change with a draft PR on this repo in the meantime, wdyt?

BOLT04 avatar Nov 25 '22 10:11 BOLT04

@BOLT04 Yeah, our workflow still try to install NodeJS projects with lockVersion: 1, so we have still problems described in the https://github.com/asyncapi/.github/issues/123 issue.

Could we do this change with a draft PR on this repo in the meantime, wdyt?

Hmm 😅 Which PR? I don't see PR related to this problem in this repo. Could you clarify?

magicmatatjahu avatar Nov 25 '22 11:11 magicmatatjahu

ohh sorry, i meant if we could open a draft PR on this repo, changing to npm ci. It doesn't exist yet 😅 @magicmatatjahu

BOLT04 avatar Nov 25 '22 11:11 BOLT04

Aaa ok, sorry for misunderstanding! Yeah. you can create draft PR and check it :)

magicmatatjahu avatar Nov 25 '22 11:11 magicmatatjahu

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Jul 08 '23 00:07 github-actions[bot]

Still relevant

smoya avatar Feb 04 '24 06:02 smoya

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Jun 04 '24 00:06 github-actions[bot]