nodejs-ws-template icon indicating copy to clipboard operation
nodejs-ws-template copied to clipboard

feat: finish migrating to react renderer

Open ibishal opened this issue 1 year ago • 11 comments

Description

Updated this template to use react renderer

Related issue(s) #294

Screenshot from 2024-08-26 03-10-19

Screenshot from 2024-08-26 03-11-40 Screenshot from 2024-08-26 03-10-02

ibishal avatar Aug 25 '24 22:08 ibishal

Can you review this PR,

then make it support asyncapi v3 - so 2 separate PR

so that i can proceed with this

cc @derberg

ibishal avatar Aug 25 '24 22:08 ibishal

The package-lock.json is now included in the PR, and the test are working fine locally, can you rerun the test in this PR

cc @derberg

ibishal avatar Sep 03 '24 18:09 ibishal

done the reviewed changes @derberg

ibishal avatar Sep 05 '24 14:09 ibishal

pinging you again cc @derberg

ibishal avatar Sep 11 '24 13:09 ibishal

nice! did you try to use the template using https://github.com/asyncapi/nodejs-ws-template?tab=readme-ov-file#how-to-use-the-template instruction? I mean the react version?

when running ag command you need to reference local copy of react based template instead of @asyncapi/nodejs-ws-template

ig i have done that, as far as i remember

ibishal avatar Feb 25 '25 16:02 ibishal

Lets push this by this weekend, its been pending for a long time

cc @derberg

ibishal avatar Feb 25 '25 16:02 ibishal

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Jun 26 '25 00:06 github-actions[bot]

cc @derberg

ibishal avatar Jun 30 '25 03:06 ibishal

@ibishal let's better focus on moving functionality to generator directly and archiving this repo

derberg avatar Aug 18 '25 07:08 derberg