modelina icon indicating copy to clipboard operation
modelina copied to clipboard

fix: #749 Added nullable checking.

Open RobinGoussey opened this issue 3 years ago • 4 comments

Description Nullables, as Type: ['string','null'] should now return string instead of Object[].

Related issue(s) Fixes #749

RobinGoussey avatar May 13 '22 19:05 RobinGoussey

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar May 13 '22 19:05 sonarqubecloud[bot]

Pull Request Test Coverage Report for Build 2321462572

  • 34 of 35 (97.14%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.106%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/helpers/TypeHelpers.ts 23 24 95.83%
<!-- Total: 34 35
Totals Coverage Status
Change from base Build 2301968325: 0.02%
Covered Lines: 2827
Relevant Lines: 2926

💛 - Coveralls

coveralls avatar May 25 '22 14:05 coveralls

Hello, @coveralls! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in pull requests:

  • /ready-to-merge or /rtm - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
  • /do-not-merge or /dnm - This comment will block automerging even if all conditions are met and ready-to-merge label is added
  • /autoupdate or /au - This comment will add autoupdate label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict.

asyncapi-bot avatar May 25 '22 14:05 asyncapi-bot

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Sep 23 '22 00:09 github-actions[bot]