chore: add resizable property in playground
Description
- used
react-resizable-panelsto implement resizing into theeditorandoutputcomponents
File Changed
-
Content.tsx
Related issue(s) Fixes #1846
Additionals
Deploy Preview for modelina ready!
| Name | Link |
|---|---|
| Latest commit | 92dd00ddacf12889197f572feefe61352c3c2740 |
| Latest deploy log | https://app.netlify.com/sites/modelina/deploys/660300c3b56a210008d6f37a |
| Deploy Preview | https://deploy-preview-1908--modelina.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Pull Request Test Coverage Report for Build 8440033043
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 92.303%
| Totals | |
|---|---|
| Change from base Build 8323576283: | 0.0% |
| Covered Lines: | 5994 |
| Relevant Lines: | 6325 |
💛 - Coveralls
Hi @AKACHI-4, There are few things we need to fix:
-
Can you please add a bar between the editors indicating that it can be resizeable? Something similar to this:
-
Collapsing the left (input) editor should not collapse the general options.
-
Right editor along with output navigator is not being collapsed fully. Kindly fix this.
@devilkiller-ag do you have time to take a look?
@devilkiller-ag do you have time to take a look?
Hi @jonaslagoni, I think I gave my review earlier on this 🤔
Hey @devilkiller-ag, Surely look but first I have some thoughts
- Can you please add a bar between the editors indicating that it can be resizable?
yea, sure. should it be more stylish as you suggested ?
- Collapsing the left (input) editor should not collapse the general options.
yeah, got that. It should apply the same for the right panel as well.
- Right editor along with output navigator is not being collapsed fully. Kindly fix this.
actually, I intentionally did that because when I completely collapse the right panel, there's no way I'll be able to use the resizable bar again since it will be hidden inside the overflow-y.
Possible fixes :
- use low-opacity scrollbar for that.
- use
w-5for the bar, but that might look too wide.
some observation : I checked vs-code, and its a fix there too. This means that in the 2-panel view, if we collapse right one, there's no way to get it back.
kindly suggest some more improvement i can perform on pr.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Any update on this @AKACHI-4?
Hey @devilkiller-ag I will PR next week due to exam this week. tho
Hi @AKACHI-4, did you had a chance to look up on this work?
Yeah @devilkiller-ag I did changes locally, but sort of incomplete what left is the arrow sign which changes direction on majority width.
Will do a raw commit by this evening.
Hi @AKACHI-4 any updates on this? Feel free to ask if you are facing any issues.