modelina icon indicating copy to clipboard operation
modelina copied to clipboard

chore: add resizable property in playground

Open AKACHI-4 opened this issue 1 year ago • 13 comments

Description

  • used react-resizable-panels to implement resizing into the editor and output components

File Changed

  • Content.tsx

Related issue(s) Fixes #1846

Additionals Playground _ Modelina

AKACHI-4 avatar Mar 22 '24 07:03 AKACHI-4

Deploy Preview for modelina ready!

Name Link
Latest commit 92dd00ddacf12889197f572feefe61352c3c2740
Latest deploy log https://app.netlify.com/sites/modelina/deploys/660300c3b56a210008d6f37a
Deploy Preview https://deploy-preview-1908--modelina.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 22 '24 07:03 netlify[bot]

Pull Request Test Coverage Report for Build 8440033043

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.303%

Totals Coverage Status
Change from base Build 8323576283: 0.0%
Covered Lines: 5994
Relevant Lines: 6325

💛 - Coveralls

coveralls avatar Mar 26 '24 09:03 coveralls

Hi @AKACHI-4, There are few things we need to fix:

  • Can you please add a bar between the editors indicating that it can be resizeable? Something similar to this: image

  • Collapsing the left (input) editor should not collapse the general options.

  • Right editor along with output navigator is not being collapsed fully. Kindly fix this.

devilkiller-ag avatar Mar 26 '24 09:03 devilkiller-ag

@devilkiller-ag do you have time to take a look?

jonaslagoni avatar Mar 26 '24 11:03 jonaslagoni

@devilkiller-ag do you have time to take a look?

Hi @jonaslagoni, I think I gave my review earlier on this 🤔

devilkiller-ag avatar Mar 26 '24 15:03 devilkiller-ag

Hey @devilkiller-ag, Surely look but first I have some thoughts

  • Can you please add a bar between the editors indicating that it can be resizable?

yea, sure. should it be more stylish as you suggested ?

  • Collapsing the left (input) editor should not collapse the general options.

yeah, got that. It should apply the same for the right panel as well.

  • Right editor along with output navigator is not being collapsed fully. Kindly fix this.

actually, I intentionally did that because when I completely collapse the right panel, there's no way I'll be able to use the resizable bar again since it will be hidden inside the overflow-y.

Possible fixes :

  • use low-opacity scrollbar for that.
  • use w-5 for the bar, but that might look too wide.

some observation : I checked vs-code, and its a fix there too. This means that in the 2-panel view, if we collapse right one, there's no way to get it back.

AKACHI-4 avatar Mar 26 '24 17:03 AKACHI-4

kindly suggest some more improvement i can perform on pr.

AKACHI-4 avatar Mar 26 '24 17:03 AKACHI-4

Any update on this @AKACHI-4?

devilkiller-ag avatar Mar 31 '24 10:03 devilkiller-ag

Hey @devilkiller-ag I will PR next week due to exam this week. tho

AKACHI-4 avatar Mar 31 '24 14:03 AKACHI-4

Hi @AKACHI-4, did you had a chance to look up on this work?

devilkiller-ag avatar Apr 14 '24 07:04 devilkiller-ag

Yeah @devilkiller-ag I did changes locally, but sort of incomplete what left is the arrow sign which changes direction on majority width.

Will do a raw commit by this evening.

AKACHI-4 avatar Apr 14 '24 07:04 AKACHI-4

Hi @AKACHI-4 any updates on this? Feel free to ask if you are facing any issues.

devilkiller-ag avatar May 06 '24 13:05 devilkiller-ag