pyvo icon indicating copy to clipboard operation
pyvo copied to clipboard

Updated SIA up-casing behavior

Open d-giles opened this issue 1 year ago • 3 comments

Modified the behavior of the SIA service where it would upcase all format keywords. Modified to upcase keywords "ALL", "METADATA", and "GRAPHIC", otherwise the parameter is passed unchanged. The format "GRAPHIC-xyz" will capitalize "GRAPHIC" and leave the rest unchanged.

Tests have been added to check that the formats are cased as expected. Variable names have been updated to be more descriptive.

Edit: changed description of PR to reflect updates.

d-giles avatar May 06 '24 18:05 d-giles

We don't need to worry about the changelog failure above, I can move the entry to the bugfix section when/if I'm cutting a bugfix release (not yet sure we will have that or go ahead with the feature release sometimes soon).

bsipocz avatar May 08 '24 17:05 bsipocz

@pllim - please add @d-giles to the org, so I don't need to approve CI after each commit

bsipocz avatar May 08 '24 20:05 bsipocz

Re: https://github.com/astropy/pyvo/pull/545#issuecomment-2101393540

Added. Hope it helps!

pllim avatar May 08 '24 20:05 pllim

Given the imminent 1.5.2 release, I go ahead and rebase this to fix the conflict, and rerun with a fixed CI.

bsipocz avatar May 22 '24 01:05 bsipocz