Move astropy.samp to pyvo.astropy_samp

[MridulS]

To fix #155 and another take on https://github.com/astropy/pyvo/pull/239

[bsipocz]

@astropy/coordinators -- how is Mridul not yet part of the org? Please resolve it, so we don't need to approve CI on his PRs.

[pllim]

Ooops. I have invited @MridulS to astropy-contributors. Hope this helps!

[pllim]

E astropy.samp.errors.SAMPProxyError: <SAMPProxyError 2: 'Client cli#2 not subscribed to MType table.load.votable'>

Not sure what is going on but @tomdonaldson and/or @astrofrog would be the best person to advice for this effort.

astropy already dropped Python 3.8 but hopefully should not matter here since we rarely touch astropy.samp.

[ManonMarchand]

It looks like the naming convention for the modules here is pyvo.group.standard or pyvo.standard which would give pyvo.app.samp or pyvo.samp. Which one do you all think is best ?

Also I cannot run the tests from this branch. It looks like they are disabled since this https://github.com/astropy/astropy/commit/7c7e48836c84685ee53c0e785547960db959a490 ?

[msdemlei]

On Mon, Apr 15, 2024 at 02:07:09AM -0700, Manon Marchand wrote:

It looks like the naming convention for the modules here is pyvo.group.standard or pyvo.standard which would give pyvo.app.samp or pyvo.samp. Which one do you all think is best?

I'm all for short paths, so it would be pyvo.samp for me.

There is a bit of trouble there because pyvo.samp already contains a few convenience wrappers, but from the top of my head I don't think there are name clashes between the old astropy samp namespace and the old pyvo.samp.

[pllim]

I cannot run the tests from this branch

Feel free to disable them in your branch here.

p.s. Though by now I think Mridul's contract is done and he has moved on, so maybe a pyvo maintainer should take this over.