astropy
adding support for calibration queries
This is an API equivalent to the "associated calibrations" tab on the Gemini Archive website. It uses comparable searches to the observation data and returns results one would see on that tab.
query_calibrations_for_region - This allows you to get calibrations against a cone search at some coordinate
query_calibrations_for_object - This gets calibrations related to a search by object name
query_calibrations_for_criteria - This allows for a richer query with multiple terms and returns the calibrations
query_calibrations_raw - For expert use, this allows more free-form search terms based on a URL from the website
Note this pull request depends on BeautifulSoup. It's already an astropy dependency, but I wasn't sure if there's a desire to avoid it.
Hello @olyoberdorf! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Comment last updated at 2022-08-18 00:45:34 UTC
Note this pull request depends on BeautifulSoup. It's already an astropy dependency, but I wasn't sure if there's a desire to avoid it.
Using any of the already required dependencies is fair game and encouraged (https://astroquery.readthedocs.io/en/latest/#requirements). If for some reason a supported version needs to be bumped to a newer minimal, that could very much be OK, but needs discussion (we tend not to drop support unless it comes up as a blocker). The least preferable thing, adding any new dependencies should certainly need a prior discussion as in many times it may be possible to work around with the current dependencies.
Adding some narrative docs would be welcome, too. Please note though that some changes to the gemini docs was merged very recently (now we test the docs examples), so this would need a rebase to pick up those changes.
And I forgot to mention the changelog, please add an entry there, too. Thanks!