astropy.github.com icon indicating copy to clipboard operation
astropy.github.com copied to clipboard
verified publisher icon astropy

Search on main page results in warning because of use of http

Open braingram opened this issue 1 year ago • 4 comments

I'm using firefox on a mac m1, when I visit: https://www.astropy.org/ and use the search box I am presented with a warning: Screenshot 2024-07-16 at 4 45 20 PM due to the use of http instead of https in the search. https://github.com/astropy/astropy.github.com/blob/745c64e0a6dabd11a5b73de1ad0c083a9585ab33/index.html#L94

braingram avatar Jul 16 '24 20:07 braingram

Yes, I think we can switch to HTTPS. Are you interested to submit a PR? Thanks!

pllim avatar Jul 16 '24 20:07 pllim

Thanks. No, I'm not at all familiar with this repository.

braingram avatar Jul 16 '24 20:07 braingram

Let me double check with @eteq though. I vaguely remember some discussion on why it is still HTTP but I don't remember where we talked about it.

pllim avatar Jul 16 '24 21:07 pllim

Maybe it was this comment but maybe the comment is only for dev docs and not stable docs? 🤷‍♀️

https://github.com/astropy/astropy.github.com/pull/591#issuecomment-2121188535

pllim avatar Jul 16 '24 21:07 pllim

Turns out it was everywhere. See https://github.com/astropy/astropy.github.com/pull/623

pllim avatar Sep 24 '24 15:09 pllim