astropy-tutorials icon indicating copy to clipboard operation
astropy-tutorials copied to clipboard

Spectroscopic Data Reduction: trace, extract, calibrate & data

Open keflavich opened this issue 4 years ago • 3 comments

Tutorial 3 following #508, #510

keflavich avatar Dec 14 '21 17:12 keflavich

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

I fixed the issues with the color-excess tutorial (causing your builds to fail), so if you rebase this and your other PRs (sorry...) the CI should start working again. Sorry for the headache!

adrn avatar Jan 04 '22 17:01 adrn

Overall looks good. My only ask is to make the notebook titles in this series more clear (Part 1, 2, 3 etc with sub-titles defining the end goal of each notebook).

eblur avatar Feb 17 '22 15:02 eblur

I've addressed @eblur's comments and applied some other changes that were needed (header, import location, etc)

keflavich avatar Aug 22 '22 15:08 keflavich