astro-cli icon indicating copy to clipboard operation
astro-cli copied to clipboard

fix truncated env vars

Open sunkickr opened this issue 3 years ago β€’ 1 comments

Description

PR that fixes an issue were env vars that contained a "=" were truncated

🎟 Issue(s)

  • https://github.com/astronomer/astro-cli/issues/590

πŸ§ͺ Functional Testing

manual tested

πŸ“Έ Screenshots

Add screenshots to illustrate the validity of these changes.

πŸ“‹ Checklist

  • [X] Rebased from the main (or release if patching) branch (before testing)
  • [x] Ran make test before taking out of draft
  • [x] Ran make lint before taking out of draft
  • [ ] Added/updated applicable tests
  • [X] Tested against Astro-API (if necessary).
  • [ ] Tested against Houston-API and Astronomer (if necessary).
  • [ ] Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • [ ] Updated any related documentation

sunkickr avatar Aug 12 '22 14:08 sunkickr

Codecov Report

Merging #686 (a24a0ae) into main (e24b654) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   85.90%   85.91%           
=======================================
  Files          93       93           
  Lines        7338     7341    +3     
=======================================
+ Hits         6304     6307    +3     
  Misses        639      639           
  Partials      395      395           
Impacted Files Coverage Ξ”
cloud/deployment/deployment_variable.go 89.11% <100.00%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update e24b654...a24a0ae. Read the comment docs.

codecov[bot] avatar Aug 12 '22 14:08 codecov[bot]