astro-cli icon indicating copy to clipboard operation
astro-cli copied to clipboard

Deployment Name Flag

Open sunkickr opened this issue 3 years ago • 2 comments

Description

Allows users to specify a deployment with the deployments name on commands: astro deployment delete, update, logs, and variable list, create, update

🎟 Issue(s)

  • https://github.com/astronomer/astro-cli/issues/668

🧪 Functional Testing

  • added tests

📸 Screenshots

📋 Checklist

  • [X] Rebased from the main (or release if patching) branch (before testing)
  • [x] Ran make test before taking out of draft
  • [X] Ran make lint before taking out of draft
  • [x] Added/updated applicable tests
  • [x] Tested against Astro-API (if necessary).
  • [ ] Tested against Houston-API and Astronomer (if necessary).
  • [ ] Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • [ ] Updated any related documentation

sunkickr avatar Aug 03 '22 16:08 sunkickr

Codecov Report

Merging #673 (6fbb97c) into main (e24b654) will increase coverage by 0.03%. The diff coverage is 86.30%.

:exclamation: Current head 6fbb97c differs from pull request most recent head ed182ab. Consider uploading reports for the commit ed182ab to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   85.90%   85.94%   +0.03%     
==========================================
  Files          93       93              
  Lines        7338     7370      +32     
==========================================
+ Hits         6304     6334      +30     
- Misses        639      640       +1     
- Partials      395      396       +1     
Impacted Files Coverage Δ
cloud/deploy/deploy.go 60.22% <75.00%> (-0.16%) :arrow_down:
cloud/deployment/deployment.go 91.44% <82.60%> (+0.56%) :arrow_up:
cloud/deployment/deployment_variable.go 88.94% <100.00%> (ø)
cmd/cloud/deploy.go 84.09% <100.00%> (+0.36%) :arrow_up:
cmd/cloud/deployment.go 91.46% <100.00%> (+0.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e24b654...ed182ab. Read the comment docs.

codecov[bot] avatar Aug 03 '22 16:08 codecov[bot]

What happens if a user passes both deploymentId and deploymentName?

kushalmalani avatar Aug 05 '22 20:08 kushalmalani