astro-cli icon indicating copy to clipboard operation
astro-cli copied to clipboard

Wait for status

Open sunkickr opened this issue 3 years ago β€’ 3 comments

Description

Add a wait flag to deployment create

🎟 Issue(s)

πŸ§ͺ Functional Testing

πŸ“Έ Screenshots

πŸ“‹ Checklist

  • [X] Rebased from the main (or release if patching) branch (before testing)
  • [ ] Ran make test before taking out of draft
  • [x] Ran make lint before taking out of draft
  • [ ] Added/updated applicable tests
  • [ ] Tested against Astro-API (if necessary).
  • [ ] Tested against Houston-API and Astronomer (if necessary).
  • [ ] Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • [ ] Updated any related documentation

sunkickr avatar Aug 03 '22 15:08 sunkickr

Codecov Report

Merging #672 (c95afdc) into main (2a6441a) will decrease coverage by 0.02%. The diff coverage is 82.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   85.94%   85.91%   -0.03%     
==========================================
  Files          93       93              
  Lines        7370     7406      +36     
==========================================
+ Hits         6334     6363      +29     
- Misses        640      644       +4     
- Partials      396      399       +3     
Impacted Files Coverage Ξ”
cloud/deployment/deployment.go 90.37% <81.08%> (-1.08%) :arrow_down:
cmd/cloud/deployment.go 91.50% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 2a6441a...c95afdc. Read the comment docs.

codecov[bot] avatar Aug 03 '22 19:08 codecov[bot]

@sunkickr Are you ready to take this out of Draft or is there more pending work on this PR?

kushalmalani avatar Aug 10 '22 16:08 kushalmalani

@kushalmalani still need to write tests

sunkickr avatar Aug 12 '22 19:08 sunkickr