astro-cli
astro-cli copied to clipboard
Wait for status
Description
Add a wait flag to deployment create
π Issue(s)
π§ͺ Functional Testing
πΈ Screenshots
π Checklist
- [X] Rebased from the main (or release if patching) branch (before testing)
- [ ] Ran
make testbefore taking out of draft - [x] Ran
make lintbefore taking out of draft - [ ] Added/updated applicable tests
- [ ] Tested against Astro-API (if necessary).
- [ ] Tested against Houston-API and Astronomer (if necessary).
- [ ] Communicated to/tagged owners of respective clients potentially impacted by these changes.
- [ ] Updated any related documentation
Codecov Report
Merging #672 (c95afdc) into main (2a6441a) will decrease coverage by
0.02%. The diff coverage is82.05%.
@@ Coverage Diff @@
## main #672 +/- ##
==========================================
- Coverage 85.94% 85.91% -0.03%
==========================================
Files 93 93
Lines 7370 7406 +36
==========================================
+ Hits 6334 6363 +29
- Misses 640 644 +4
- Partials 396 399 +3
| Impacted Files | Coverage Ξ | |
|---|---|---|
| cloud/deployment/deployment.go | 90.37% <81.08%> (-1.08%) |
:arrow_down: |
| cmd/cloud/deployment.go | 91.50% <100.00%> (+0.04%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact),ΓΈ = not affected,? = missing dataPowered by Codecov. Last update 2a6441a...c95afdc. Read the comment docs.
@sunkickr Are you ready to take this out of Draft or is there more pending work on this PR?
@kushalmalani still need to write tests