astro-cli icon indicating copy to clipboard operation
astro-cli copied to clipboard

Move internal to public client for all API calls

Open kushalmalani opened this issue 3 years ago • 1 comments

Description

Describe the purpose of this pull request.

Move internal to public client for all API calls to allow for new RBAC launch

🎟 Issue(s)

Related #642

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • [x] Rebased from the main (or release if patching) branch (before testing)
  • [x] Ran make test before taking out of draft
  • [x] Ran make lint before taking out of draft
  • [ ] Added/updated applicable tests
  • [ ] Tested against Astro-API (if necessary).
  • [ ] Tested against Houston-API and Astronomer (if necessary).
  • [ ] Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • [ ] Updated any related documentation

kushalmalani avatar Aug 01 '22 23:08 kushalmalani

Codecov Report

Merging #669 (c8c9f03) into main (0c29608) will increase coverage by 0.05%. The diff coverage is 89.65%.

:exclamation: Current head c8c9f03 differs from pull request most recent head 11c3802. Consider uploading reports for the commit 11c3802 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   86.66%   86.71%   +0.05%     
==========================================
  Files          97       97              
  Lines        8231     8177      -54     
==========================================
- Hits         7133     7091      -42     
+ Misses        668      660       -8     
+ Partials      430      426       -4     
Impacted Files Coverage Δ
astro-client/client.go 67.44% <ø> (+1.17%) :arrow_up:
cloud/deployment/deployment.go 89.18% <50.00%> (-1.55%) :arrow_down:
astro-client/astro.go 100.00% <100.00%> (ø)
cloud/deploy/deploy.go 60.70% <100.00%> (+0.17%) :arrow_up:
cmd/cloud/setup.go 56.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c29608...11c3802. Read the comment docs.

codecov[bot] avatar Aug 01 '22 23:08 codecov[bot]

All the commands are working except astro deployment create. I am getting the following error: Screen Shot 2022-09-01 at 10 44 35 AM

sunkickr avatar Sep 01 '22 14:09 sunkickr

All the commands are working except astro deployment create. I am getting the following error: Screen Shot 2022-09-01 at 10 44 35 AM

We confirmed offline, it was some other issue specific to the David's system.

kushalmalani avatar Sep 07 '22 04:09 kushalmalani