astro-cli icon indicating copy to clipboard operation
astro-cli copied to clipboard
Published 2 months ago • verified publisher icon astronomer

get values from astrohub API for scheduleraumin, scheduleraumax etc

Open kushalmalani opened this issue 3 years ago • 3 comments

https://github.com/astro-projects/astro-cli/blob/f5f8330289de0280c0596262f040bfbcff075ad0/cloud/deployment/deployment.go#L28-L36

kushalmalani avatar May 26 '22 20:05 kushalmalani

@frank-ye Was this addressed? If yes, Can you link the PR to the ticket

kushalmalani avatar Aug 31 '22 17:08 kushalmalani

We're going to remove this configurability based on https://www.notion.so/astronomerio/Scheduler-Sizing-and-UX-in-Astro-b7ac9800b2a34b14bd1cf35253f8ee1b, should be addressed via: https://github.com/astronomer/astro/pull/2642

Thanks for the reminder :)

frank-ye avatar Aug 31 '22 17:08 frank-ye

I dont think we should close this yet, until we can validate there is no additional work required on the CLI. This ticket was primarily to pull the config from astrohub instead of hardcoding it in the CLI. Same thing we do with workerQueueOption, We need to build the same logic with deploymentConfigOptions.

kushalmalani avatar Aug 31 '22 17:08 kushalmalani

https://github.com/astronomer/astro-cli/pull/1138

kushalmalani avatar Apr 11 '23 19:04 kushalmalani