astro-cli icon indicating copy to clipboard operation
astro-cli copied to clipboard

Edge case where two people push the same nextTag at the same time

Open kushalmalani opened this issue 3 years ago • 0 comments

Description:

Our Docker Registry deployment path was recently updated to work in the format:

registry + "/" + currentWorkspace.OrganizationId + "/" + deploymentId + ":" + nextTag

Example:

images.astronomer-dev.cloud/ckmzjm22937931d35puw3tcdo/ckrb433xy4030541dvkqu4msb6q:deploy-2021-07-19T21-34

Need to confirm:

We believe that the race condition occurs when two users update a deployment image within the same minute the user with the image that finishes uploading last overrides the image that completed first.

Found in cloud/deploy/deploy.go.

https://github.com/astro-projects/astro-cli/blob/f5f8330289de0280c0596262f040bfbcff075ad0/cloud/deploy/deploy.go#L128

Original Ticket - https://github.com/astro-projects/astro-cli/issues/9

kushalmalani avatar May 26 '22 20:05 kushalmalani