node-replay icon indicating copy to clipboard operation
node-replay copied to clipboard

request occasionally fires multiple end events

Open justincy opened this issue 9 years ago • 0 comments

When using request the end events are sometimes fired multiple times. This is because request includes a fix for a bug in node core. request will fire an end when it see a close event if it hasn't yet seen an end event. Sometimes request is receiving the close event from node-replay first which causes it to fire an end event and then request receives the end event from node-replay and fires another end event.

A quick fix is disabling these lines of code but I don't know if that would have any unintended consequences.

I believe it only occurs on some requests because it's a race condition.

justincy avatar Aug 15 '16 21:08 justincy