rules_ts icon indicating copy to clipboard operation
rules_ts copied to clipboard
verified publisher icon aspect-build

[Bug]: ts_config doesn't provide a JsInfo

Open gregmagolan opened this issue 3 years ago • 1 comments

See https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1670621678898069?thread_ts=1670620951.407769&cid=CEZUUKQ6P for more context

gregmagolan avatar Dec 09 '22 21:12 gregmagolan

Transitive npm deps from the tsconfig attribute in ts_project should not get forwarded to downstream consumers via the JsInfo it provides or via runfiles.

gregmagolan avatar Dec 09 '22 22:12 gregmagolan

I put together a repro in https://github.com/Toxaris/ts_config_deps_repro.

Toxaris avatar Dec 11 '22 00:12 Toxaris

We figured out in Slack that disabling workers helps. I updated the https://github.com/Toxaris/ts_config_deps_repro to also demonstrate this work around.

Toxaris avatar Dec 12 '22 12:12 Toxaris

Gotcha. That is quite possible as there seem to be a few more gremlins in worker mode. cc @thesayyn

gregmagolan avatar Dec 12 '22 17:12 gregmagolan

@Toxaris The latest release of rules_ts has a big refactor for worker mode. When you have a chance could you please try turning working mode back on in your repro?

gregmagolan avatar Feb 06 '23 06:02 gregmagolan

Fix will be included in v1.13.0 which I'm going to cut right after https://github.com/aspect-build/rules_ts/pull/316 lands

gregmagolan avatar Feb 11 '23 22:02 gregmagolan