askorama
Bugfix/561 - facets limit not works
Related to issue 561
I fixed the casting of the facets config in code, that was preventing to get the correct property value from the set config.
Also added tests for both default and non default limit.
Please Note: I didn't find mention, in code, specifically in the declaration of StringFacetDefinition, to the size field, then I updated the docs removing it and replacing it with limit, where needed.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| orama-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 9, 2024 3:36pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for your contribution. I don't understand the last test: the number of quotes is 11. Which expected behavior should we have when a limit of 20 is specified? Could you also add a test for a limit of 5 (less than 11)?
Yep, I will add it, @allevo
I set 20 and not 11 just to make it more "realistic", given that usually you set the number of items you need as results for pagination, instead of the number of the items you will receive
+1 Appreciate the effort. Would love to see this merged as it's causing me issues in production
@micheleriva Apologies for tag, but would it be possible to get this merged and released? It's an important fix
Hi @Sinister747, @allevo and I will review this again and try to release this by tomorrow. Thanks for the patience
@Sinister747 released right now
Thank you very much, really appreciate it. Enjoy your weekend everyone