gocd-build-github-pull-requests icon indicating copy to clipboard operation
gocd-build-github-pull-requests copied to clipboard

Add checkout attempts for stability and fix minor issues

Open SOVALINUX opened this issue 10 years ago • 6 comments

  1. Add checkout attempts, since stats showed it can be very unstable regarding of network
  2. Fix pom and resource versions

SOVALINUX avatar Aug 27 '15 23:08 SOVALINUX

I was thinking about adding checkout property to configuration form, bit not sure, that this is really useful functionality

SOVALINUX avatar Aug 27 '15 23:08 SOVALINUX

@SOVALINUX Sorry for not getting back sooner. Can you shed some more light on this change? What was the scenario you observed and how this fix helps?

ashwanthkumar avatar Sep 03 '15 18:09 ashwanthkumar

In my logs were a lot of errors that material checkout failed, since git fetch command returned exit code 1 or 128. As I said above it may be caused by network problems. After applying this fix locally it became much better. Actually this fix is a bit dirty. Better to add checkout timeout for 10 minutes for example. And within this timeout there might be several attempts

SOVALINUX avatar Sep 07 '15 20:09 SOVALINUX

Thanks @SOVALINUX. If you could just fix the conflicts, I would merge the changes.

ashwanthkumar avatar Sep 24 '15 02:09 ashwanthkumar

@ashwanthkumar - Were the ongoing issues of 128 errors addressed in other PRs or versions that this attempted to address but died on the vine in 2015.

Related to https://github.com/ashwanthkumar/gocd-build-github-pull-requests/issues/144 and https://github.com/ashwanthkumar/gocd-build-github-pull-requests/issues/118

gregoryfischer avatar Apr 02 '20 19:04 gregoryfischer

Any news on this?

MPV avatar May 24 '23 15:05 MPV