gocd-build-github-pull-requests icon indicating copy to clipboard operation
gocd-build-github-pull-requests copied to clipboard

Blacklist priority not working as expected for feature branches

Open mikeycmccarthy opened this issue 8 years ago • 4 comments

Hi, I think that either the blacklist/whitelist has a bug, or the documentation is incorrect/misleading.

The documentation states 'The blacklist takes precedence over whitelist. I.e. a branch will not be built if the blacklist pattern matches to the branch name'.

On our setup we have 'master' as the blacklist pattern, and * as the whitelist pattern, which I assume to mean build any branches EXCEPT master.

I can clearly see that master branch is being built:

09:07:01.778 [go] setting environment variable 'GO_SCM_XXX_LABEL' to value '8f429c4a5517b462bf973b1a947697a15e2f35b8' 09:07:01.778 [go] setting environment variable 'GO_SCM_XXX_URL' to value '[email protected]' 09:07:01.778 [go] setting environment variable 'GO_SCM_XXX_BRANCHBLACKLIST' to value 'master' 09:07:01.778 [go] setting environment variable 'GO_SCM_XXX_BRANCHWHITELIST' to value '*' 09:07:01.778 [go] setting environment variable 'GO_SCM_XXX_CURRENT_BRANCH' to value 'master'

Is this my misunderstanding of the plugin?

Thanks

mikeycmccarthy avatar Aug 15 '17 09:08 mikeycmccarthy

@mikeycmccarthy Can you please help me understand if the logs you saw were from the first time build or master is getting built on every push ?

ashwanthkumar avatar Aug 15 '17 15:08 ashwanthkumar

Let me check and confirm, thanks

mikeycmccarthy avatar Aug 17 '17 13:08 mikeycmccarthy

I can confirm that I am also having the same issue, I have a blacklist of "master,develop" and a whitelist of * but the build keeps pulling master.

digitalcherry avatar Oct 10 '17 14:10 digitalcherry

Same issue here. I simply added "master" into the blacklist and my pipeline never triggers anymore, no matter on which branch commits are pushed.

dokaspar avatar Oct 23 '17 07:10 dokaspar