masterPortfolio icon indicating copy to clipboard operation
masterPortfolio copied to clipboard

Add .env to the Project For Github Token

Open saiteja13427 opened this issue 3 years ago • 3 comments

This PR removes the GitHub token and username from the git_data_fetcher.mjs and adds it to a new env file.

Changes

  1. Added an env.example file with token and username which users will have to rename to .env.
  2. Added new instructions in README.
  3. Added dotenv package as a dev dependency as it is needed to use .env variables.
  4. Added .env to gitignore.

This PR addresses #220

@ashutosh1919 do have a look!

saiteja13427 avatar Sep 17 '22 09:09 saiteja13427

@saiteja13427 can you please investigate why the build fails?

ashutosh1919 avatar Sep 18 '22 21:09 ashutosh1919

Yes @ashutosh1919 not yet able to understand why is the build failing. Will figure it out and update

saiteja13427 avatar Sep 19 '22 08:09 saiteja13427

@saiteja13427 Also we need to figure out a way to remove the package-lock.json file from the repo. Everytime we update a package, it shows huge change in that file.

ashutosh1919 avatar Sep 19 '22 17:09 ashutosh1919

@saiteja13427 & @ashutosh1919 someone with the privileges need to retrigger the builds from GitHub actions. This issue occurs if there are simultaneous PRs and the build is going on simultaneously.

tamojit-123 avatar Oct 27 '22 12:10 tamojit-123

@tamojit-123 I have actually tried running the test again back then but that did not work out actually. Will check this again and see.

saiteja13427 avatar Oct 27 '22 13:10 saiteja13427

Please refer to this link might help: https://stackoverflow.com/questions/68021121/fsevents-not-accessible-from-jest-haste-map I did it the same way or else Update your branch through this PR : https://github.com/ashutosh1919/masterPortfolio/pull/254

tamojit-123 avatar Oct 27 '22 16:10 tamojit-123

@tamojit-123 The issue was an incompatibility of the dotenv version actually, I resolved it.

So, I am closing #254

saiteja13427 avatar Oct 27 '22 16:10 saiteja13427

@ashutosh1919 Do have a look at this PR

Will merge it once you have a look.

We will have to update our testing npm versions and lock file versions to do updates to packages in future. We can also change our tests from node 10.x 12.x to 14.x and 16.x maybe.

saiteja13427 avatar Oct 28 '22 17:10 saiteja13427

Alright merging it then!

saiteja13427 avatar Nov 03 '22 17:11 saiteja13427