02:20 - Code Reviews and CI (30m)

[asgrim]

• [x] Make it work on Travis (15m)
  • Run phpunit, ~~behat~~ (bit more complex, also not implementing...), phpstan, phpcs
• [ ] Create sample PR for a collaborative code review
  • Things to get picked up on:
    • Bad code style: fix is to AUTOMATE (demo using phpcs - just basic PSR-0 to 2 for brevity)
    • Make a service final that doesn't have an interface
    • Forget some type declarations
    • Unnecessary variable declarations
    • Missing some tests - how to identify (scrutinizer?)
    • Inject some weird global state issue
    • Write a rubbish feature that's not clear, doesn't use examples (but not in an OBVIOUS way...)
    • Needs documentation
    • Stick an XSS vulnerability in there for good measure