unpic icon indicating copy to clipboard operation
unpic copied to clipboard
verified publisher icon ascorbic

feat: add basehub support

Open julianbenegas opened this issue 1 year ago • 3 comments

julianbenegas avatar Nov 19 '24 21:11 julianbenegas

🔼 upvote

matiasperz avatar Nov 20 '24 03:11 matiasperz

Ah, can you update the tests. It looks like the expected URLs are wrong. There are instructions in the contributing guide to running them locally

Fixed! Still not 100% sure of when fit=cover should be set. I think it'll be fine for most cases though.

julianbenegas avatar Nov 25 '24 23:11 julianbenegas

hey @ascorbic, i fixed the tests here eb12cd5 💪

julianbenegas avatar Dec 08 '24 23:12 julianbenegas