abcd icon indicating copy to clipboard operation
abcd copied to clipboard

Create python package, add type hints and structured types for dataset

Open lebrice opened this issue 4 years ago • 3 comments

Hey there, thanks for you amazing work!

I've added a few things to your repo which I'd like to offer as a contribution:

  • Reorganized the source code into a python package that's easy to install
  • Added some type hints to a bunch of functions
  • Created a typed dict "schema" for the data so that the contents of the datasets can be easily understood directly in code
  • Simplified the argument parsing logic using dataclasses and simple-parsing

Let me know if you have any questions. Thanks again!

lebrice avatar Sep 09 '21 15:09 lebrice

Hi Fabrice, thanks for the contributions, which all look really helpful! However, it seems you have also changed the folder structure of the repo by adding an abcd directory. Would it be possible to include your changes, but have the main structure remain the same? The updates themselves (such as adding better type hints) are great!

ghost avatar Jan 04 '22 18:01 ghost

Hey @dchen-asapp , thanks for taking a look.

Its not possible to create a python package without the folder structure changing slightly (at least for the code).

Whats worrying about the folder structure changing, if you dont mind me asking? Are you worried it might break some of your data pipelines or automation scripts or something?

lebrice avatar Jan 04 '22 18:01 lebrice

I'm mostly afraid that the main training script will break since these things are often path dependent.

ghost avatar Jan 04 '22 20:01 ghost