libaudiodecoder icon indicating copy to clipboard operation
libaudiodecoder copied to clipboard

inline methods (member functions) link issues

Open avinash-gupta-in opened this issue 1 year ago • 1 comments

Many functions are inline, as we know in such case we have to provide the definition within the header file. We are getting link issues with such functions. https://stackoverflow.com/questions/953710/inline-function-linker-error

avinash-gupta-in avatar Mar 28 '24 07:03 avinash-gupta-in

Thanks for bringing this to my attention. You're right, but I won't have time to fix this for a week or two. I would accept a pull request that removes inline from all the functions, if you want to send one over. There's no need for them to be inline and I agree it's done incorrectly and will cause linker issues in some cases.

asantoni avatar Apr 02 '24 01:04 asantoni

Fixed in main branch

asantoni avatar Feb 02 '25 21:02 asantoni