eigen icon indicating copy to clipboard operation
eigen copied to clipboard

feat: Android widget - Featured Artwork

Open chr-tatu opened this issue 10 months ago • 2 comments

Description

PR Checklist

  • [ ] I have tested my changes on the following platforms:
    • [ ] Android.
    • [ ] iOS.
  • [x] I hid my changes behind a feature flag, or they don't need one.
  • [ ] I have included screenshots or videos at least on Android, or I have not changed the UI.
  • [ ] I have added tests, or my changes don't require any.
  • [ ] I added an app state migration, or my changes do not require one.
  • [ ] I have documented any follow-up work that this PR will require, or it does not require any.
  • [ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • [ ] I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

chr-tatu avatar Jun 16 '25 08:06 chr-tatu

Warnings
:warning:

❌ **It seems like you added some non WebP images to Eigen, please convert them to WebPs using source images/script.sh script **

This PR contains the following changes:

  • Android user-facing changes (Add the new Featured Artworks widget to see daily beautiful, curated artworks right on your Android home screen. - chr-tatu)

Generated by :no_entry_sign: dangerJS against 9ff93b69bd1ec6b04f27fed43d667cb4b4a54b6e

ArtsyOpenSource avatar Jun 16 '25 08:06 ArtsyOpenSource

the test that failed is a flaky one that I fixed in main, if you rebase its gonna be okay

gkartalis avatar Jun 27 '25 15:06 gkartalis

Thank you folks for helping me move this PR forward and for all your suggestions! 🙏

I'll merge it tomorrow morning if there's not major bug I notice or no other improvement suggestions.

chr-tatu avatar Jul 02 '25 13:07 chr-tatu

@chr-tatu If you are planning on QA'ng this tomorrow and review bugs + fix them before Friday, then today is a good day to merge. However if you are planning on giving yourself some time to QA, I would recommend you merge this only after code freeze tomorrow to give yourself some room to address QA comments, if any.

MounirDhahri avatar Jul 02 '25 13:07 MounirDhahri

Oh! that makes sense, so I can test on the beta. I'll merge now, then! Thanks, @MounirDhahri !

@chr-tatu If you are planning on QA'ng this tomorrow and review bugs + fix them before Friday, then today is a good day to merge. However if you are planning on giving yourself some time to QA, I would recommend you merge this only after code freeze tomorrow to give yourself some room to address QA comments, if any.

chr-tatu avatar Jul 02 '25 14:07 chr-tatu

fyi @chr-tatu the beta is broken temporarily https://artsy.slack.com/archives/C02BAQ5K7/p1751465748900939

MounirDhahri avatar Jul 02 '25 14:07 MounirDhahri