eigen icon indicating copy to clipboard operation
eigen copied to clipboard

feat: add galleries near you rail

Open MounirDhahri opened this issue 1 year ago • 1 comments

This PR resolves []

Description

This PR adds a galleries near you rail to the home view.

As you can see, lots of changes on the schema just to support this rail, which we might remove eventually 🤷 . This is why I would be more in favour of discarding most of my changes in favour of treating the the typename as feature toggle

PR Checklist

  • [ ] I have tested my changes on iOS and Android.
  • [ ] I hid my changes behind a feature flag, or they don't need one.
  • [ ] I have included screenshots or videos, or I have not changed the UI.
  • [ ] I have added tests, or my changes don't require any.
  • [ ] I added an app state migration, or my changes do not require one.
  • [ ] I have documented any follow-up work that this PR will require, or it does not require any.
  • [ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • [ ] I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • add galleries near you rail - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

MounirDhahri avatar Aug 07 '24 15:08 MounirDhahri

This PR contains the following changes:

  • Cross-platform user-facing changes (add galleries near you rail - mounir)

Generated by :no_entry_sign: dangerJS against 700aaee1d3a5aae37dd97a018fe371cae402947f

ArtsyOpenSource avatar Aug 30 '24 10:08 ArtsyOpenSource

@olerichter00 I am not sure what you mean by moving the data to MP - I assumed it's already there now

MounirDhahri avatar Aug 30 '24 12:08 MounirDhahri

@olerichter00 I am not sure what you mean by moving the data to MP - I assumed it's already there now

Sorry, this is a bit ambiguous. I was referring to this comment:https://github.com/artsy/eigen/pull/10571#discussion_r1738468570

olerichter00 avatar Aug 30 '24 13:08 olerichter00