activeadmin_settings_cached icon indicating copy to clipboard operation
activeadmin_settings_cached copied to clipboard

Simple ActiveAdmin extension for rails_setting_cache > 2

Open ngelx opened this issue 2 years ago • 5 comments

ActiveAdmin interface for rails_setting_cache > 2

This is an ActiveAdmin extension to add the interface to handle rails-setting-cached v2. For prior version I was using this gem but seems to be dead or with no activity.

Link to the gist ActiveAdmin interface for v2

ngelx avatar Jun 21 '23 06:06 ngelx

Hi @ngelx. This gem a little bit dead because I don't use ruby in my work right now. But some work to update this gem to support v2 was done in branch https://github.com/artofhuman/activeadmin_settings_cached/tree/2.0 but I suppose not all.

So, If you have a solution, we can merge it to upstream

artofhuman avatar Jun 21 '23 07:06 artofhuman

Also, there are some problems with CI, and I think we have to migrate to GitHub actions

artofhuman avatar Jun 21 '23 07:06 artofhuman

Hi @artofhuman,

My first approach was to start updating this code, but after a while of struggling I dropped it in favor of a more simple KISS. To be honest, I don't see the point on having most of the logic in clases Coercions, Model and Options. It should be more than enough with a view, controller and a helper that just extend the ActiveAdmin interface.

What I would recommend to do is to rebuild this gem following this kiss principe. We can put a note on the readme about the breaking change with version 2, which BTW was most probably going to happen anyway just for the upgrade to rails-settings-cache to v2. Cleaner code, easy code, easier to maintain.

Second option is to just start a new gem, something very original like activeadmin_settings_cached_2 😄

I don't have much time, but I can work on this on some free time.

Let me know your thoughts.

ngelx avatar Jun 23 '23 04:06 ngelx

@ngelx Sorry for delay. I agree that code may be cleaner, and maybe it's not necessary to do some coercions, etc. If you want, I can give you maintenance rights for this repo.

artofhuman avatar Jun 28 '23 17:06 artofhuman

No problem at all! thanks. As you mentioned before, I will also moved CI to Github actions.

ngelx avatar Jun 29 '23 04:06 ngelx