Arthur Passos
Arthur Passos
Ping for a review @alexey-milovidov
@alesapin updated
@alesapin ping for a review.
@alesapin ping
All comments have been addressed / answered, CI failures do not seem related (checked against this [query](https://play.clickhouse.com/play?user=play#c2VsZWN0IAp0b1N0YXJ0T2ZIb3VyKGNoZWNrX3N0YXJ0X3RpbWUpIGFzIGQsCmNvdW50KCksIGdyb3VwVW5pcUFycmF5KHB1bGxfcmVxdWVzdF9udW1iZXIpCmZyb20gY2hlY2tzIHdoZXJlICcyMDIzLTAyLTAxJyA8PSBjaGVja19zdGFydF90aW1lIGFuZCB0ZXN0X25hbWUgbGlrZSAnJXRlc3RfY3JlYXRlX29yX2Ryb3BfdGFibGVzX2R1cmluZ19iYWNrdXAlJyBhbmQgY2hlY2tfbmFtZSBsaWtlICclSW50ZWdyYXRpb24lJyBhbmQgdGVzdF9zdGF0dXMgaW4gKCdGQUlMJywgJ0ZMQUtZJywgJ0VSUk9SJykgZ3JvdXAgYnkgZCBvcmRlciBieSBkIGRlc2M=) and it seems like it's failing on other PRs as well. Please correct...
@alexey-milovidov it seems like `test_multiple_disks/test.py::test_background_move[mt]` has passed, the only other failure I see is `test_alias_column`, which is known to be flaky. Is there anything pending for us to get this...
> The integration test has to be fixed before merging to master. What integration test? `test_alias_column`?
> @arthurpassos, all tests from @vzakaznikov have to be moved to the ClickHouse repository as either functional or integration tests. I am not sure porting ALL tests is an option....
> > The integration test has to be fixed before merging to master. > > What integration test? `test_alias_column`? It turns out `test_alias_column` failure was indeed related to this PR,...
test_s3_cluster/test.py::test_parallel_distributed_insert_select_with_schema_inference -- https://github.com/ClickHouse/ClickHouse/pull/46488 stress tests -- gwp-asan https://github.com/ClickHouse/ClickHouse/pull/45226#issuecomment-1431205026 Found an unrelated PR with the same CI failures that got merged yesterday: https://github.com/ClickHouse/ClickHouse/pull/46452. So I think it's safe to assum CI...