arrayfire icon indicating copy to clipboard operation
arrayfire copied to clipboard

[build] RUN_TESTS missing unified tests

Open willyborn opened this issue 1 year ago • 1 comments

RUN_TESTS only executes cpu, opencl and cuda test programs. The unified programs are compiled although never executed in RUN_TESTS.

Description

master in 3.9.0

Reproducible Code and/or Steps

System Information

Arrayfire: 3.9.0 (master: Commit 01c89484) Windows 10

Checklist

  • [ ] Using the latest available ArrayFire release
  • [ ] GPU drivers are up to date

willyborn avatar Oct 18 '24 18:10 willyborn

On line 277 of https://github.com/arrayfire/arrayfire/blob/bdda3b3ea454030099871319c724eec4ee205bed/test/CMakeLists.txt I see the following:

# TODO(umar): Create this executable separately
if(NOT ${backend} STREQUAL "unified" OR ${target} STREQUAL "backend_unified")
  af_add_test(${target} ${backend} ${mt_args_SERIAL})
endif()

@umar456 do you remember what was your intention here?

If I comment out if and endif then the unified tests are run with ctest

christophe-murphy avatar Oct 23 '24 14:10 christophe-murphy