aroman
Added functionality to share and edit code
Hello, a couple of friends and i were taking part in the mcgill hackathon that happened last weekend and we used ur project to add a feature the can allow sharing and editing code. we saw from ur project that that was ur next step after the chat system. doing this project gave us an ability to learn how to contribute to open source as half the hackathon was spent figuring out the code and learning coffeescript/jade/nodejs/express for the very first time. For the hackathon, we did redesign the front end since we had a front end developer in the team and demoed with our design but in this pull request, ur front-end is still the same. we got the code sharing bit to work in a way that was real time too (i.e. if the code window is open in both sides of the chat, then clicking Propogate Hack would instantaneously modify code in both windows). We also added a Code button to open the modal (but u can still use
Your story was so inspiring - that's what the spirit of the Open Source community is all about!
Hackerchat was also my first exposure to Express.js/Jade/Coffeescript, and the hackathon experience is really all about exploring new things.
Out next step was to indeed allow the sharing and editing of code. I was able to give it a try and it worked perfectly, nice job! I would also love to see your redesign if it's live somewhere. :+1:
@aroman, ready to merge?
i dont mind giving u link to redesign but urs is much better. and this is awesome news...thnx guys :) let me know when merge is complete so i can give this awesome news to my team
On Wed, Feb 26, 2014 at 3:02 PM, Victor Lourng [email protected]:
Your story was so inspiring - that's what the spirit of the Open Source community is all about!
Hackerchat was also my first exposure to Express.js/Jade/Coffeescript, and the hackathon experience is really all about exploring new things.
Out next step was to indeed allow the sharing and editing of code. I was able to give it a try and it worked perfectly, nice job! I would also love to see your redesign if it's live somewhere. [image: :+1:]
@aroman https://github.com/aroman, ready to merge?
[image: Status]https://github-camo.global.ssl.fastly.net/ad2813369be60d8a2533d958c62cd05627c799f5/687474703a2f2f696d672e736869656c64732e696f2f636f666665652f70617373696e672e706e673f636f6c6f723d677265656e
Reply to this email directly or view it on GitHubhttps://github.com/aroman/hackerchat/pull/1#issuecomment-36169850 .
USman
here is the link to the redesign but it not as details as urs :P
http://107.170.69.246:3000/
Hi Usman,
Thanks so much for sharing your story! I'm really glad our project was helpful to you. I took a look at your version of the site, and it's very nice — it works well for me.
However, the site you built is actually different (cooler, in some ways!) than the idea we originally had with the site. In HackChat (your site), the code editor is used as a "shared textbox" for writing code. In HackerChat (our site), the code editor is used to write plugins for the platform itself — clicking "propogate hack" doesn't update the other person's text editor, it actually evaluates and executes the code on both/everyone's account.
That said, we didn't have time to completely finish this feature so the actual evaluation step is hard coded — though the data is sent across in realtime. For the demo, we hardcoded it so that whatever code you type in the "hack" window (which you can open by sending <hack> as a chat message), it always makes messages prefixed with a backtick () execute the javascript code. e.g., ``2+2 would return as a message 4 for both users, whereas before typing <hack> and hitting Propagate hack!, that would do nothing special.
So, although I really appreciate the pull request, I think it would be best to keep our versions separate. They each do different things with the "hack" feature. That's not bad of course, but I think you might be best off pushing your whole version (including the new design) to your own account. We would be happy to link to your fork from ours — that might be the best way of handling the open-sourcing in this case.
What do you both think?
its all upto u guys!!! :) i have no problem with what you decide....maybe u can use our code as the next step to do ur execution. regardless im glad that we got an opportunity to do this!!! ill keep on watching this project and its progress.