Updating BTreeMap::from to Rust 1.56 syntax

Open FL33TW00D opened this issue 4 years ago • 3 comments

This changes the old format for instantiating Maps from .iter().cloned().collect() to the new BTreeMap::from syntax introduced in Rust 1.56.

Please feel free to reject if this jump in MSRV (1.49 -> 1.56) is too large - just a QOL change I spotted digging around the codebase.

Jan 07 '22 14:01 FL33TW00D

Obviously the tests are failing due to the CI running on 1.46, I'll leave this open for now and we can evaluate. I personally don't believe the msrv jump is worth it to save 10loc but that doesn't mean the PR is worth closing immediately. Thanks!

Jan 13 '22 10:01 arlyon

By the way @FL33TW00D I have added a discussion about 0.14, feel free to add your thoughts

Jan 13 '22 10:01 arlyon

Obviously the tests are failing due to the CI running on 1.46, I'll leave this open for now and we can evaluate. I personally don't believe the msrv jump is worth it to save 10loc but that doesn't mean the PR is worth closing immediately. Thanks!

100% Agree - can leave sitting until something that requires an MSRV jump comes up.

Jan 13 '22 11:01 FL33TW00D

Codecov Report

Merging #136 (19bbe5c) into master (ec392c2) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #136   +/-   ##
======================================
  Coverage    5.36%   5.36%           
======================================
  Files         150     150           
  Lines       14526   14526           
======================================
  Hits          780     780           
  Misses      13746   13746

Impacted Files	Coverage Δ
openapi/src/metadata.rs	`0.00% <ø> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Oct 08 '22 12:10 codecov[bot]