tg-bot-api icon indicating copy to clipboard operation
tg-bot-api copied to clipboard

Unresolved references in Telegram Bot API 7.2 update

Open kravetsone opened this issue 1 year ago • 8 comments

The new Telegram Bot API 7.2 objects do not exist in the schema, but other objects reference them

image image

kravetsone avatar Mar 31 '24 18:03 kravetsone

Looks like this is caused by absence of description for these objects...

ENCRYPTEDFOREVER avatar Apr 03 '24 22:04 ENCRYPTEDFOREVER

Looks like this is caused by absence of description for these objects...

Yes! We have already discussed this with the author. Would you like to do a PR?)

kravetsone avatar Apr 03 '24 22:04 kravetsone

Yes! We have already discussed this with the author.

Any suggestions on fix?

ENCRYPTEDFOREVER avatar Apr 03 '24 22:04 ENCRYPTEDFOREVER

Yes! We have already discussed this with the author.

Any suggestions on fix?

I'm not familiar with Rust much, so I didn't do it myself. The author suggests leaving an empty string in the absence of a description

Unfortunately, the documentation is poorly done(

I tried to write in @BotTalk chats / bot support, but I got no result...

kravetsone avatar Apr 03 '24 22:04 kravetsone

I don't think I have time now to do a proper PR but for a dirty fix you can go to src/extractor.rs, line 66 and prepend

else if select_any.peek().matches(&table) {
    State::GetObjectFields {
        name: elem,
        description: RawDescription::default(),
    }
}

before the 'else' block.

ENCRYPTEDFOREVER avatar Apr 03 '24 23:04 ENCRYPTEDFOREVER

It looks like issue was fixed after they added descriptions to entities like BusinessLocation, BusinessIntro, etc 😅

ark0f avatar Jun 23 '24 20:06 ark0f

can confirm, it has been fixed since then. the issue might be closed

nitreojs avatar Jun 24 '24 17:06 nitreojs

The issue might be closed

It might reoccur in the future, it's better to implement such case handling...

ENCRYPTEDFOREVER avatar Jun 27 '24 19:06 ENCRYPTEDFOREVER