simple-markdown icon indicating copy to clipboard operation
simple-markdown copied to clipboard

Text is cut on Android after upgrade to Expo SDK 33 and react 16.8.3

Open fimkap opened this issue 6 years ago • 4 comments

We noticed that after upgrade to Expo SDK 33 and react 16.8.3 under some conditions the text is cut at the end of paragraphs. We work with Hebrew (RTL). It happens only on Android with larger screens. It looks like wrong calculation of internal size of a view based on the text. Playing with padding or margins in styles will not fix it. The simple-markdown used from react-native-markdown-view, we tried to change to another markdown package but it has the same issue. What can be the reason for that and how it can be fixed?

fimkap avatar Oct 22 '19 08:10 fimkap

Hi fimkap,

This sounds like it's likely a react-native bug rather than a markdown bug, especially if this repro'd with a different package (although I'm interested in which package: if it's another simple-markdown based react-native package, it could be some awkward interaction between this project and react-native).

If you have a small project I could look at that reproduces this issue in an android simulator I'll look at it, although I'm not sure how much help I'll be able to be.

ariabuckles avatar Nov 03 '19 22:11 ariabuckles

Hi, I'll prepare a small project so you can take a look. I think another project was react-native-markdown-renderer. Thanks.

fimkap avatar Nov 04 '19 13:11 fimkap

@ariabuckles Here's the project: https://github.com/fimkap/markdown-cutoff you can run it in Android emulator taking a bigger model like Pixel 3 then you'll see the issue

fimkap avatar Nov 04 '19 15:11 fimkap

the screenshot Screen Shot 2019-11-04 at 17 38 40

fimkap avatar Nov 04 '19 15:11 fimkap