open-props icon indicating copy to clipboard operation
open-props copied to clipboard

"normalize dark": Conflict Between "oklch Gray" and the Classic Gray

Open mobalti opened this issue 2 years ago • 2 comments

The oklch gray colors override the classic gray in "normalize dark".

You can reproduce the bug by adding:

@import "https://unpkg.com/open-props/gray-oklch.min.css";

to "normalize dark".

I suggest changing the name of the oklch gray colors from "--gray-1" to "--ok-gray-1" or "--gray-1-oklch".

mobalti avatar Aug 10 '23 09:08 mobalti

i see! i figured folks would use either or but you're wanting to have both on the page? I also imagined the oklch grays would overtake the old ones as the library moved forward with HDR color, but maybe having them named a bit separate is good.

name could also be --hdr-gray-1 and stuff, to separate with even further based on it's quality and not the space?

argyleink avatar Aug 15 '23 17:08 argyleink

great news that we will move forward with HDR colors!

mobalti avatar Aug 15 '23 19:08 mobalti