notifications-engine icon indicating copy to clipboard operation
notifications-engine copied to clipboard

Support Generic Webhook Calls to GitHub with GitHub App Authentication

Open jwenz723 opened this issue 4 years ago • 2 comments

I'm not sure if this issue should be submitted in this repo or in argocd-notifications, hopefully here is ok.

Currently the github service supports only the Create Status api.

Notifications to other GitHub API endpoints can be achieved using the generic webhook service, but this method does not support GitHub App Authentication.

GitHub App authentication is preferable to me because at my organization it can be quite difficult to obtain a GitHub machine/service user account, but it is quite easy to receive a new GitHub App instance.

Please provide the ability in the GitHub service to build custom notifications to GitHub. I believe the majority, if not all, of the GitHub REST API could be supported with the current implementation of the webhook service, so a similar (or exact duplicate) implementation but capable of authenticating using a GitHub App would be greatly appreciated.

There are 2 possible implementation options that come to mind:

  1. Add a new method in the GitHub service that is capable of doing custom webhook invocations
  2. Add a GitHub App authentication method to the generic webhook service

jwenz723 avatar Jul 13 '21 20:07 jwenz723

any particular plans regarding this one?

DpoBoceka avatar Sep 07 '21 05:09 DpoBoceka

I also miss the option to pass custom revision to the commit status call. At the moment the revision is always taken from revisionTemplate = "{{.app.status.sync.revision}}".

ragnarpa avatar Mar 31 '22 15:03 ragnarpa