feat: Bump kubernetes to 1.28.4
This is a copy of PR https://github.com/argoproj/gitops-engine/pull/556 but rebased to argoproj/gitops-engine master at this time.
Quality Gate passed
The SonarCloud Quality Gate passed, but some issues were introduced.
2 New issues
0 Security Hotspots
No data about Coverage
3.2% Duplication on New Code
Codecov Report
Attention: 37 lines in your changes are missing coverage. Please review.
Comparison is base (
7921242) 54.42% compared to head (1c9f565) 54.78%.
| Files | Patch % | Lines |
|---|---|---|
| pkg/utils/kube/resource_ops.go | 0.00% | 30 Missing :warning: |
| pkg/sync/sync_context.go | 83.33% | 4 Missing and 2 partials :warning: |
| pkg/utils/kube/kube.go | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 54.42% 54.78% +0.36%
==========================================
Files 41 41
Lines 4803 4636 -167
==========================================
- Hits 2614 2540 -74
+ Misses 1977 1899 -78
+ Partials 212 197 -15
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Draft PR in argo-cd repo testing this PR: https://github.com/argoproj/argo-cd/pull/16967
Hey! What is the state of this PR? Any chances to get this merged soon?
@MisterMX gonna work with the author of this newer PR to try to get the upgrade done: https://github.com/argoproj/gitops-engine/pull/566/files
Hi @asaf-erlich,
Thanks for the PR! This will be superseded by #566, and it seems pretty likely that that will be the PR to be merged. Closing for now - if you feel otherwise feel free to reopen.