argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

PodDisruptionBudget not syncing with RespectIgnoreDifferences flag

Open zawistowskipiotr opened this issue 1 year ago • 8 comments

Checklist:

  • [x] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • [x] I've included steps to reproduce the bug.
  • [x] I've pasted the output of argocd version.

Describe the bug

When syncing an application with out of sync status of object PDB and set RespectIgnoreDifferences flag to true - object remains out of sync with status successfully synced.

To Reproduce

Sync application with PDB object with status out of sync and set RespectIgnoreDifferences flag to true.

Expected behavior

PDB object is synced

Screenshots

Zrzut ekranu 2024-05-15 133425 Zrzut ekranu 2024-05-15 133556

Version

argocd: v2.11.0+d3f33c0
  BuildDate: 2024-05-07T16:01:41Z
  GitCommit: d3f33c00197e7f1d16f2a73ce1aeced464b07175
  GitTreeState: clean
  GoVersion: go1.21.9
  Compiler: gc
  Platform: linux/amd64

Logs

None during the operation.

zawistowskipiotr avatar May 15 '24 11:05 zawistowskipiotr

Have you observed that only for PodDisruptionBudgets or also for other type of resources?

jannfis avatar May 15 '24 15:05 jannfis

@jannfis Only for PodDisruptionBudgets

zawistowskipiotr avatar May 16 '24 06:05 zawistowskipiotr

Hey 👋 we also observed this issue. To fix it we tried using server-side apply and it did not change the behaviour. Only editing the resource fixed the issue. Argo version

{
    "Version": "v2.10.6+d504d2b",
    "BuildDate": "2024-04-05T00:27:47Z",
    "GitCommit": "d504d2b1d92f0cf831a124a5fd1a96ee29fa7679",
    "GitTreeState": "clean",
    "GoVersion": "go1.21.3",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v5.2.1 2023-10-19T20:13:51Z",
    "HelmVersion": "v3.14.3+gf03cc04",
    "KubectlVersion": "v0.26.11",
    "JsonnetVersion": "v0.20.0"
}

I had never seen this behaviour previous to 2.10 but we did not test a downgrade to see if it fixes the problem

Edit: We only saw this happening when the diffs were in the matcher labels

joaosilva15 avatar May 16 '24 07:05 joaosilva15

hello, I have similar issue with PDB object, I'm also using v2.11.0

diablo39 avatar Jun 05 '24 07:06 diablo39

I'm having the same issue in version v2.11.3. I've resolved this by either deleting the PDB or updating the manifest manually. image

This only affects spec.selector.matchLables but is correct in metadata.labels image

alexkivars avatar Jun 18 '24 10:06 alexkivars

Same issue with v2.11.4 (with spec.selector.matchLablels as well). It is resolved by deleting the PDB, but it is a painful operation when managing many PaaS...

JulienDelacroix avatar Sep 03 '24 09:09 JulienDelacroix

I can even confirm that this is still an issue in ArgoCD v2.12.3

flickers avatar Sep 03 '24 10:09 flickers

Issue still persist on ArgoCD version v2.12.4+27d1e64. In my case, the manifest differs in:

spec:
  selector:
    matchLabels:
      key: value

seffparker avatar Oct 10 '24 05:10 seffparker

Can confirm this is still an issue in v2.13.1

alexkivars avatar Dec 09 '24 13:12 alexkivars