argo-python-dsl icon indicating copy to clipboard operation
argo-python-dsl copied to clipboard
verified publisher icon argoproj-labs

Validate resulting YAML/JSON against JSONschema

Open moshewe opened this issue 4 years ago • 2 comments

Describe the bug Some workflows generated by the library are not valid. E.g. workflows with name over 63 characters in length. To Reproduce Create a workflow with a name 64 characters long. Expected behaviour Receive an error when setting name so be longer than 63 characters.

Screenshots image This workflow was submitted via the DSL and failed only when run.

moshewe avatar Apr 13 '21 19:04 moshewe

Is this a requirement imposed by Kubernetes, rather than Argo? Perhaps it's a limitation of RFC1123? There is some K8S documentation on this but it has to do with labels/selectors.

flaviuvadan avatar Apr 14 '21 14:04 flaviuvadan

Regardless of where this limitation comes from, this workflow shouldn't have been accepted in a submit call. I hope these things are covered in the official JSONschema...

moshewe avatar Apr 15 '21 19:04 moshewe