[DE-684] confuse about some code

[Korov]

com.arangodb.springframework.repository.query.derived.DerivedQueryCreator#createCriteria

the code final boolean checkUnique = part.getProperty().toDotPath().split(".").length <= 1; should be final boolean checkUnique = part.getProperty().toDotPath().split("\\.").length <= 1;?

[DevPJ9]

@Korov If you are asking regrading the regex, then I think the second approach (final boolean checkUnique = part.getProperty().toDotPath().split("\\.").length <= 1;) is the correct one.

[Korov]

@DevPJ9 Can I create a PR to fix it?

[DevPJ9]

Yeah sure. I am not related to arongdb. So I am not sure about rest.

However, you can raise a PR and mention it to someone who has admin rights or reviewing right to this repo, so that they can merge your PR.

[rashtao]

This looks like a bug to me. AFAICS, fixing the regex with \\. would only lead to further bugs, namely if checkUnique is false then checkUniqueLocation(Part) is never invoked and uniqueLocation is null. This would generate AQL problems, i.e. accessing location field with null[0], null[1], in case the point is represented as an array of coordinate components.

Note that the code paths for checkUnique=false are in fact not tested.

[rashtao]

Internal tracking: DE-684