python-arango icon indicating copy to clipboard operation
python-arango copied to clipboard

3.10: Read from Followers (allow dirty read)

Open tjoubert opened this issue 3 years ago • 1 comments

Added allow_dirty_read optional parameter to methods for the following:

  • Single document reads (GET /_api/document)
  • Batch document reads (PUT /_api/document?onlyget=true)
  • Read-only AQL queries (POST /_api/cursor)
  • The edge API (GET /_api/edges)
  • Read-only Stream Transactions and their sub-operations (POST /_api/transaction/begin etc.)

https://github.com/arangodb/docs/blob/main/3.10/release-notes-api-changes310.md#read-from-followers

tjoubert avatar Sep 30 '22 06:09 tjoubert

Codecov Report

Merging #222 (14760e3) into main (ef48710) will decrease coverage by 0.07%. The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   99.23%   99.15%   -0.08%     
==========================================
  Files          26       26              
  Lines        3770     3776       +6     
==========================================
+ Hits         3741     3744       +3     
- Misses         29       32       +3     
Impacted Files Coverage Δ
arango/collection.py 99.39% <60.00%> (-0.25%) :arrow_down:
arango/executor.py 99.39% <75.00%> (-0.61%) :arrow_down:
arango/aql.py 94.89% <100.00%> (ø)
arango/database.py 99.85% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 30 '22 07:09 codecov-commenter

Do we need to make allow_dirty_read nullable? It seems like we can get away with just defaulting to False.

Thanks @joowani. I have updated the default value of the allow_dirty_read parameter to False.

tjoubert avatar Oct 04 '22 07:10 tjoubert