core icon indicating copy to clipboard operation
core copied to clipboard

[WIP]: decouple framework and ens

Open clauBv23 opened this issue 1 year ago • 0 comments

Description

Proposal idea, following what was discussed.

notion page for reference

Since this is a proposal, only Dao Factory and Dao registry tests were updated to follow the new contract.

changes summary:

  • Dao
    • DaoRegistry, removed all ens registrar code, is it no longer needed in the registry
    • DaoFactory, new action param added in the createDao and logic to execute those actions
  • Plugin Repo
    • PluginRegistry, removed all ens registrar code, is it no longer needed in the registry
    • PluginRepoFactory, remove all subdomain-related params
  • Tests => dao related tests fixed to work with new contracts
  • Deploy scripts
    • Reordered to first deploy the registries and later the ens registrar
    • changed the plugin creation and a new function to define subdomain in a separate step after the plugin creation

Gist link

Task ID: OS-1300

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ ] I have selected the correct base branch.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran all tests with success and extended them if necessary.
  • [ ] I have updated the CHANGELOG.md file in the root folder.
  • [ ] I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • [ ] I have updated the UPDATE_CHECKLIST file in the root folder.
  • [ ] I have updated the Subgraph and added a QA URL to the description of this PR.

clauBv23 avatar Apr 30 '24 09:04 clauBv23