core icon indicating copy to clipboard operation
core copied to clipboard
verified publisher icon aragon

Feature/deploy script improvement

Open novaknole opened this issue 1 year ago • 3 comments

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-?

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ ] I have selected the correct base branch.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran all tests with success and extended them if necessary.
  • [ ] I have updated the CHANGELOG.md file in the root folder.
  • [ ] I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • [ ] I have updated the UPDATE_CHECKLIST file in the root folder.
  • [ ] I have updated the Subgraph and added a QA URL to the description of this PR.

novaknole avatar Apr 29 '24 10:04 novaknole

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

:white_check_mark: novaknole
:white_check_mark: brickpop
:white_check_mark: jordaniza
:x: Giorgi Lagidze

Giorgi Lagidze seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 29 '24 10:04 CLAassistant

Please improve the title (https://www.conventionalcommits.org/en/v1.0.0/) and description. Also tick the checklist, so that this PR will show up correctly in the releases page, if this should become a release at some point. @Rekard0 Will this be a tagged release?

heueristik avatar Apr 30 '24 09:04 heueristik

This branch needs some merge conflicts fixed && we need to rename MANAGINGDAO_XX to MANAGEMENT_DAO_XX

EDIT: resolved in commit https://github.com/aragon/osx/pull/582/commits/d4dfbb9f27dd5e91e05bb6797a00cca2e21c0c2e

jordaniza avatar May 03 '24 10:05 jordaniza