nova-proxy icon indicating copy to clipboard operation
nova-proxy copied to clipboard

HTTPS support

Open SudoCat opened this issue 5 years ago • 6 comments

It doesn't seem to be possible to use this proxy with a HTTPS/SSL host - is that correct?

SudoCat avatar Apr 28 '20 15:04 SudoCat

That's correct. We're not supporting hosts with HTTPS/SSL mainly because Nova Proxy was planned to be used as a sidecar proxy, then we can use https in outer layers e.g a load balancer.

marconi1992 avatar Apr 28 '20 15:04 marconi1992

good catch! @SudoCat, we'll elaborate more that explanation and update the Readme file accordingly.

marconi1992 avatar Apr 28 '20 15:04 marconi1992

Thanks for the lightning fast response! I must admit that this sort of thing is far outside my area of expertise, but we're hoping to use the ara framework to help us slowly migrate our front end away from a monolithic java ecommerce platform; I'm worried this limitation might prove to be an impassable blocker for our use case.

Would there be any plans to add SSL support to the proxy layer, or would we need to consider forking/utilising an alternative?

SudoCat avatar Apr 28 '20 16:04 SudoCat

Unfortunately, we don't have plans to add SSL support. We guess decoding the response to parse the HTML, as well as, coding it back could add performance issues. However, as I said it's only I guess. Let's keep open this issue and we'll make a proof of concept to see what we get.

marconi1992 avatar Apr 29 '20 01:04 marconi1992

I'm interested in this as well. Would you be okay with me raising a PR to add this functionality?

zeenotheinventor avatar Apr 29 '20 13:04 zeenotheinventor

Sure @zeenotheinventor feel free to do it, I'll really appreciate it.

marconi1992 avatar Apr 29 '20 14:04 marconi1992