aptmac
aptmac
I'm not sure what's happening here, will have to take a look at why the rest of the checks haven't triggered.
I took a bit more of a look around some of our forks, and I'm not seeing the issue I posted in the comment above: https://github.com/openjdk/jmc/pull/588#issuecomment-2353862443. I'm curious what happens...
I took this branch and ran the actions on my own fork, there's a style issue that needs to be fixed by running `mvn spotless:apply`, but the fix for Mac...
Not sure what's going on with the checks here, but it's only showing the one jcheck for me, similar to https://github.com/openjdk/jmc/pull/588. Wonder what happened to the other CI actions.
> > Not sure what's going on with the checks here, but it's only showing the one jcheck for me, similar to #588. > > Wonder what happened to the...
> I think "Martin Skarsaune" has not enabled the workflow run in his forked repo. That might be it, I'll have to poke around a bit more. His first handful...
Will have to go back over this one, looks like the test case isn't able to find the lz4-java class that we're trying to use: ``` NotificationModelTest>RjmxTestCase.mcTestCaseBefore:288->RjmxTestCase.createDefaultServerDesciptor:194 � NoClassDefFound net/jpountz/lz4/LZ4FrameInputStream...
Hm, taking a look at the jar that's pulled in from maven central, the packages aren't exported: ``` Manifest-Version: 1.0 Automatic-Module-Name: org.lz4.java Build-Jdk-Spec: 21 Bundle-ManifestVersion: 2 Bundle-Name: lz4-java Bundle-SymbolicName: lz4-java...
I contributed a PR to the new lz4-java repo, which should fix the package exports: https://github.com/yawkat/lz4-java/pull/28 Will need to check back here once it's released and verify that it actually...