aptly-dev
feat: Add etcd database support
improve concurrent access and high availability of aptly with the help of the characteristics of etcd
Fixes #
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
Checklist
- [x] unit-test added (if change is algorithm)
- [x] functional test added/updated (if change is functional)
- [x] man page updated (if applicable)
- [x] bash completion updated (if applicable)
- [x] documentation updated
- [x] author name in
AUTHORS
@hudeng-go Looking good to me. What do you think of this comment on the other ticket? https://github.com/aptly-dev/aptly/pull/1022#issuecomment-1031567248
@hudeng-go Tests failed... https://github.com/aptly-dev/aptly/runs/5140408342?check_suite_focus=true They also log a lot and take quite a long time, which will eat our free allowance of GH actions... Can you think of a solution?
@hudeng-go Tests failed... https://github.com/aptly-dev/aptly/runs/5140408342?check_suite_focus=true They also log a lot and take quite a long time, which will eat our free allowance of GH actions... Can you think of a solution?
Sorry, it took a long time to link etcd when migrating data. We are looking for the reason.
@hudeng-go I had to stop the CI once again, as it was stuck... Can we make the script so that it would crash at the first error, so we don't continue a clearly failing test?
@hudeng-go I had to stop the CI once again, as it was stuck... Can we make the script so that it would crash at the first error, so we don't continue a clearly failing test?
I have modified the migration script to exit with an error. Sorry again.
@hudeng-go I had to stop the CI once again, as it was stuck... Can we make the script so that it would crash at the first error, so we don't continue a clearly failing test?
In my environment, data can be migrated to normally. I don't know why I can't connect to etcd database in GH action environment.
@hudeng-go I had to stop the CI once again, as it was stuck... Can we make the script so that it would crash at the first error, so we don't continue a clearly failing test?
Once https://github.com/aptly-dev/aptly/pull/1033 is merged, you can rebase to ensure we have stricter timeouts for CI jobs, and avoid tests wasting our GHA allowance.
@hudeng-go I had to stop the CI once again, as it was stuck... Can we make the script so that it would crash at the first error, so we don't continue a clearly failing test?
Once #1033 is merged, you can rebase to ensure we have stricter timeouts for CI jobs, and avoid tests wasting our GHA allowance.
#1033 is merged. Please rebase this branch before carrying out further tests. Thanks!
@hudeng-go On my humble LXD image, which I use for development, etcd is using quite a lot of resources. Maybe it crashes on CI because it's too memory/cpu hungry?
@randombenj As you seem to be the most active reviewer/contributor for Aptly, could you please review this?
Hi all,
maybe we should rebase this on master first, which seems to be a bit of work.. any chance someone could help with this ?
