supercronic icon indicating copy to clipboard operation
supercronic copied to clipboard

fix(reaper): forkExec error no such file or directory & prometheus exit error

Open qianlongzt opened this issue 1 year ago • 9 comments

  1. fix https://github.com/aptible/supercronic/issues/177
  2. run reaper test in docker container
  3. use bats-action to install bats-core and bats-assert ...
  4. fix https://github.com/aptible/supercronic/issues/173

qianlongzt avatar Oct 12 '24 10:10 qianlongzt

@UserNotFound Is there anything I can do? There's no progress.

qianlongzt avatar Oct 18 '24 10:10 qianlongzt

Can you add a test for this case?

Also, i'm not sure if it would be related, but there's another issue listed related to this feature, if you could patch that here in this PR is would streamline review and release. https://github.com/aptible/supercronic/issues/173

UserNotFound avatar Oct 18 '24 18:10 UserNotFound

@UserNotFound

I added the test and ran the reaper test in Docker The bats-core action needs to be trusted bats-core/[email protected] is not allowed to be used in aptible/supercronic.

The Prometheus error may not be related; the old version has the same error. https://github.com/aptible/supercronic/releases/download/v0.2.30/supercronic-linux-amd64

qianlongzt avatar Oct 19 '24 14:10 qianlongzt

@UserNotFound i fixed prometheus http server closed error

qianlongzt avatar Oct 19 '24 15:10 qianlongzt

@UserNotFound Is there anything I can do? There's no progress.

qianlongzt avatar Oct 25 '24 08:10 qianlongzt

@UserNotFound Is there anything I can do? There's no progress.

qianlongzt avatar Nov 02 '24 11:11 qianlongzt

@UserNotFound Is there anything I can do? There's no progress.

This review is being prioritized within our team, but I don't have any information at the moment as to when that will occur.

UserNotFound avatar Nov 04 '24 23:11 UserNotFound

I have the same issue, is there a plan to merge it?

ttionya avatar Jan 15 '25 18:01 ttionya

Use the full path of Supercronic (e.g., /usr/bin/supercronic) for now, until the fix PR is merged

qianlongzt avatar Jan 15 '25 18:01 qianlongzt

@eabruzzese @almathew ping

qianlongzt avatar Jun 04 '25 07:06 qianlongzt

@qianlongzt i forked this repo and created my own release with your PR and bumped dependencies from this recently merged PR #192

if you want to check it out here it is:

https://github.com/CoreProc/supercronic/releases/tag/0.2.35

chrisbjr avatar Jun 19 '25 17:06 chrisbjr

@eloisejones @eabruzzese sorry to pester, but this PR has been waiting for review for 11 months and could really use your approval + release. (I spent 20+ minutes today chasing down the Failed to fork exec error that this fixes.) Thank you in advance!

ialexryan avatar Sep 23 '25 22:09 ialexryan

Fixed in v0.2.36

almathew avatar Sep 26 '25 15:09 almathew